Use generation sentinel for transform cache validity and add tests to prevent stale-cache leaks - #3
Merged
TiernanDeFranco merged 1 commit intoMay 7, 2026
Conversation
TiernanDeFranco
deleted the
codex/find-optimization-opportunities-in-engine-core
branch
May 7, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
global_transform_2d_validandglobal_transform_3d_validfields fromTransformRuntimeStateand their initialization innew.global_transform_*_generationto useu32::MAXas a sentinel instead of0inensure_global_2d_capacityandensure_global_3d_capacity.global_transform_*_generationagainstid.generation()and removed writes of the removed valid flags when recomputing globals inget_global_transform_2dandget_global_transform_3d.rt_ctx_nodes_transform_api_tests.rsto ensure removed-node cache entries do not leak into reused slot generations and that recomputations overwrite old cached transforms for both 2D and 3D.Testing
rt_ctx_nodes_transform_api_tests.rsviacargo test; the tests for reused-slot cache behavior and recompute behavior passed.Codex Task